Fix partial pagination which no longer returns the "hydra:next" property#4015
Merged
Merged
Conversation
meyerbaptiste
force-pushed
the
fix_partial_pagination
branch
3 times, most recently
from
February 2, 2021 18:00
9ff295c to
382957a
Compare
soyuka
reviewed
Feb 3, 2021
…greater than the number of items per page (api-platform#3967)" This reverts commit 9cecfab.
meyerbaptiste
force-pushed
the
fix_partial_pagination
branch
from
February 8, 2021 09:28
382957a to
725e66a
Compare
soyuka
approved these changes
Feb 8, 2021
Member
|
thanks @meyerbaptiste ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@jeremyteyssedre confused
$pageTotalItemswith the total number of items in the collection.$pageTotalItemsis the number of items in the current page. As a reminder, with the partial pagination we cannot determine if it is the last page. Because of this, we will always have thehydra:nextproperty, even on the last page. It is an "assumed bug".cc @clementtalleu